new plugin - pull request

Post Reply
arfa
Master Bludit
Posts: 108
Joined: Tue Jul 04, 2017 4:31 am
Location: New Zealand
Has thanked: 7 times
Been thanked: 15 times

I guess this is to admin - Edi?
I am new to gitHub and have been working on a pull request and figured I finally had it cracked - two weeks ago. It was suggested that I notify the request here - #413.

I am not sure of process but hope to get more included in the loop.

Thank you.
Kusalo
arfa
Master Bludit
Posts: 108
Joined: Tue Jul 04, 2017 4:31 am
Location: New Zealand
Has thanked: 7 times
Been thanked: 15 times

My main question is "is the pull request #413 visible to admin?"

I guess there is some review process, especially as this is my first plugin, and that it may take time but if the request is not being seen then I need to explore that further.
arfa
Master Bludit
Posts: 108
Joined: Tue Jul 04, 2017 4:31 am
Location: New Zealand
Has thanked: 7 times
Been thanked: 15 times

I am not sure of direction. A simple yes/no would suffice here.

I will be offline for most of the next 2 months so this will have to wait.

go well - kusalo
arfa
Master Bludit
Posts: 108
Joined: Tue Jul 04, 2017 4:31 am
Location: New Zealand
Has thanked: 7 times
Been thanked: 15 times

Back online after some serious jungle...

Soooo, I got mail from github: 10 Jan 2025 3.46am that:
"Merged #413 into master."
It got filed under 'notifications' :(
This is my "read-more-or-less" plugin.

Same date but 3.49am = "It's not yet online. I have to check later why."

"Chuck Norris Quotes Plugin" was #412 and there are two newer plugins.

This plugin is a relatively minor event, a part of my bludit learning curve. I have a couple more in the wings but the curve is resting a little flat.

I am no less keen on bludit but feel I need a bit of a leg up to regain some momentum.
arfa
Master Bludit
Posts: 108
Joined: Tue Jul 04, 2017 4:31 am
Location: New Zealand
Has thanked: 7 times
Been thanked: 15 times

I don't know what to say - or do.
I just checked the plugin page and #413 - Read More or Less - isn't there.

I think to delete from my repo and reposting but wonder if that might screw things up?
I don't know - and some guidance would really help.

Joho offered some suggestions, in a separate post, and that lead me on.

gitHub affirmation of merge + the presumption that it *should* be online (tho it wasn't) had me thinking it is done (but it isn't).

Taking part in community is something I enjoy and hope that I can move forward here.

cheers - kusalo
arfa
Master Bludit
Posts: 108
Joined: Tue Jul 04, 2017 4:31 am
Location: New Zealand
Has thanked: 7 times
Been thanked: 15 times

I am spending a bit more time in gitHub and saw a comment in the #413 history that it has been redacted.

I looked up 'redacted'
"especially in order to obscure or remove sensitive information"

Have I done something?
Is the plugin incorrectly formatted or badly coded?
Or...? what?

I apologise for any ignorance or some such on my part but communication is always helpful.

in anticipation ; Kusalo
User avatar
Edi
Site Admin
Posts: 3180
Joined: Sun Aug 09, 2015 5:01 pm
Location: Zurich
Has thanked: 68 times
Been thanked: 92 times
Contact:

I had not yet time to figure out what the problem is. I will do it this week.
arfa
Master Bludit
Posts: 108
Joined: Tue Jul 04, 2017 4:31 am
Location: New Zealand
Has thanked: 7 times
Been thanked: 15 times

Thank you so much for your reply. I look forward to any update.

well wishing - Kusalo
User avatar
Edi
Site Admin
Posts: 3180
Joined: Sun Aug 09, 2015 5:01 pm
Location: Zurich
Has thanked: 68 times
Been thanked: 92 times
Contact:

The plugin is now in the repository.

I made a new request, and Diego restarted the update manually. I don't know what the problem was.

Thank you for your patience!
arfa
Master Bludit
Posts: 108
Joined: Tue Jul 04, 2017 4:31 am
Location: New Zealand
Has thanked: 7 times
Been thanked: 15 times

My confidence is raised.

I appreciate the convolutions of managing anything digital and bludit-admin has a wide range of arenas to juggle. My little island is proportionately small. So, thanks for following up with that. And pass on my appreciation to Diego - you and he go back a long way.

I will continue to continue. Thank you.

be well - kusalo
Post Reply