Possible bug - external image and thumbCoverImage()

Post Reply
User avatar
bayerberg
Master Bludit
Posts: 71
Joined: Wed Jun 07, 2017 1:05 pm

Fri Nov 02, 2018 1:18 pm

Bludit 3.xx

1) $page->thumbCoverImage() returns only the cover image folder, not the image itself
2) theres a thumbCoverImage() for external images (returns the link) which is confusing because theres no file within bludit you can pull.
3) can we add CoverImageExternal() so themes can solve for images taken from CDNs ?
i do things, check them out on behance | check out startups undiluted - london's startup ecosystem
User avatar
Edi
Site Admin
Posts: 1257
Joined: Sun Aug 09, 2015 5:01 pm
Location: Zurich
Contact:

Fri Nov 02, 2018 2:09 pm

Please try the following fix:

https://github.com/bludit/bludit/issues/838
Planet Bludit, Tipps, Snippets und nützliche Links. - Newsletter, Informationen zu Bludit (auf Deutsch).
User avatar
bayerberg
Master Bludit
Posts: 71
Joined: Wed Jun 07, 2017 1:05 pm

Fri Nov 02, 2018 6:47 pm

looks like I'll have to release my themes in 3 versions - pre 3.4 and post 3.4 :) . Would be nice to get that CoverImageExternal() in as well, would help with more professional cms monkeys ;)
i do things, check them out on behance | check out startups undiluted - london's startup ecosystem
User avatar
diego
Site Admin
Posts: 633
Joined: Sat May 16, 2015 2:53 pm
Contact:

Wed Nov 07, 2018 3:54 pm

Hi,
yes there is a bug in the function but fixed as Edi mention.

About to add the function CoverImageExternal, doesnt make sense for me, because the page has one Cover Image, if the cover image is internal or external doesnt matter, the function returns what the page has assgined.
Post Reply